Skip to content

[Vue Rewrite] Start Vuex store #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Grotax merged 16 commits into from
Dec 6, 2022
Merged

[Vue Rewrite] Start Vuex store #2010

Grotax merged 16 commits into from
Dec 6, 2022

Conversation

@devlinjunker
Copy link
Contributor

@devlinjunker devlinjunker commented Dec 4, 2022 •
edited
Loading

Related to #748

Follows #1998

Start Adding Vuex Store

  • Add separate files for folder/feed state
  • Update Types and Linting
  • Use computed state for SideBar items

Testing Completed

  • Verified that App Builds with make
    • Verified that Admin Settings Page Loads on localhost (NC 25)
    • Verified that App loads on localhost (NC 25)
  • Verified that Jest Unit Tests Pass (npm run test)
    • Added Unit Tests for Store Files
    • Added Unit tests for computed state to SideBar spec file
  • Verified that linting passes (npm run lint/stylelint)
  • Verified that Folder can be added/deleted and appears/disappears from side bar in UI

Dec-03-2022 17-05-24

Up Next

@devlinjunker
moved store to separate file and started using constants for action/m…
e145602 
…utation names

Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
split store into multiple files
1a6b565 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
cleanup and renaming
1d0069e 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
clean
acbb538 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
modularize store files and fix unit tests
8b21b05 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
working unit test for local computed state
68340f6 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
lint the .ts and spec.ts files also
496a2d7 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
add more tests
c208c01 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
start on state/store tests
884664c 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
basic tests for store
513153a 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
clean
379d11c 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
clean up linting warnings
c4337ce 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
clean
5f4ce4f 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
clean up commented out lines
ab9f951 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
lint
3ed8cc4 
Signed-off-by: Devlin Junker <[email protected]>
@devlinjunker
fix admin tests
5d013cf 
Signed-off-by: Devlin Junker <[email protected]>
@Grotax Grotax merged commit cec1827 into nextcloud:vue-rewrite Dec 6, 2022
@devlinjunker devlinjunker mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@Grotax Grotax Grotax approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devlinjunker @SMillerDev @Grotax